For some reason, CLRMame Pro crashes if it attempts to scan or fix a problem while you're in the scanner, and the games are in folders instead of zip files.

Alyas
"Good... Bad... I'm the guy with the gun."

> For some reason, CLRMame Pro crashes if it attempts to scan or fix a problem
> while you're in the scanner, and the games are in folders instead of zip files.
>
> Alyas
> "Good... Bad... I'm the guy with the gun."
>


can't repeat that here....do you have an example? which file, which datfile, which operation. I just scanned and fixed several unzipped files, works fine, no problems at all. So I need a detailed error report. What's the crash message, which operations, etc...

Roman Scherzer
ClrMamePro

CLRMame Pro 3.30a. Mame32u9 from http://www.classicgaming.com/mame32qa/

First I extracted CLRMame Pro 3.30a to my CLRMame Pro folder updating it. Started the program, got the new data from Mame32. Went into Settings, have two folders under ROM-Paths, my main Mame roms folder, and a roms subfolder in my clrmame folder. Both are checked. Zip Settings have nothing checked, Zip Compression Level is set to zero.

Then went into Scanner. "Sets" and "Roms" checked, "Merged Sets", "Hide Missing" (no create missing), Missing/Case/Uneeded/Name/Size all checked for "Check" but not for "Fix".

Checksum checked, with the options: CRC32, CHD MD5/SHA, Decompress CHD, and Run Analysis checked.

Advanced Button has "Allow Not Seperated", "Optimized ROMPath Scanning", "Mark Useless ZIP Structs", and "Uneeded Check Looks for Dupes" checked.

Systems Button has everything checked except for Neo-Geo.

Then I scanned. It checked all my sets and reported back to me which ones needed changing. I went into my Mame roms folder, and moved those zips into the CLRMame roms subfolder. I extracted each one from the zips into subfolders for each game, and then moved the zips to a temporary "holding" directory.

I went back into Settings and removed the check next to the Mame roms folder, leaving just the CLRMame roms folder checked. Then I went back to the scanner, and put a checkmark next to each thing under the "Fix" column. Then I hit Fast Scan. It gets to the first folder, and I get a crash error saying:

-----

CMPRO caused an invalid page fault in
module CMPRO.EXE at 015f:004453f2.
Registers:
EAX=00000001 CS=015f EIP=004453f2 EFLGS=00010246
EBX=00000000 SS=0167 ESP=0077c37c EBP=00000000
ECX=8000a2f8 DS=0167 ESI=0077da68 FS=62f7
EDX=8000a0b8 ES=0167 EDI=00d0625c GS=0000
Bytes at CS:EIP:
8b 43 08 83 e8 10 50 e8 f2 c0 fb ff 83 c0 10 83
Stack dump:
64bd6620 00000000 00d0625c 0077da68 00000000 00000001 0077c444 00000000 0077c3fc 0077c424 004eba90 ffffffff 00457b9f 00d0625c 0077c3d0 00000000

-----

Alyas
"Good... Bad... I'm the guy with the gun."

Hmmm...still can't repeat it here...

can you repeat it? can you minimize the used sets? can you say which set is being worked on (and what is being fixed in there) when it crashed?

If you can repeat it with some small set, send me the files...

*update* if you can repeat it, try to disable one check/fix option after another and look if it still happens...
Maybe the cache folder had bad entries...so please delete it before trying again....


Roman Scherzer
ClrMamePro

This is strange, I removed the folder for alpinerd, and now it works. I put the folder back in there, and it crashes again. None of the roms are marked read-only, there are 34 of them, totally 39mb.

Update:

When CLRMame scanned my zipped alpinerd set, it showed a file had a crc32 error. When I manually placed the new version of that file in the folder, and rescanned it, now it doesn't crash. Maybe it's having a problem checking to see if a crc32 is fixable when it's not in a zip?

Update 2:

Just happened again when it hit sfrushrk. Replaced the bad crc32 roms with good copies manually, and no crash. Definitely looks like bad crc32 roms are the key.

Alyas
"Good... Bad... I'm the guy with the gun."

> This is strange, I removed the folder for alpinerd, and now it works. I put the
> folder back in there, and it crashes again. None of the roms are marked
> read-only, there are 34 of them, totally 39mb.
>
> Update:
>
> When CLRMame scanned my zipped alpinerd set, it showed a file had a crc32 error.
> When I manually placed the new version of that file in the folder, and
> rescanned it, now it doesn't crash. Maybe it's having a problem checking to see
> if a crc32 is fixable when it's not in a zip?
>
> Update 2:
>
> Just happened again when it hit sfrushrk. Replaced the bad crc32 roms with good
> copies manually, and no crash. Definitely looks like bad crc32 roms are the
> key.
>
> Alyas
> "Good... Bad... I'm the guy with the gun."
>

The issue could be caused fixing a bad structured zipfile. Be sure you got settings->zipsettings->strict zipstructure scan (or whatever it is called...topmost option) enabled before scanning.

Send me the bad files anyway.

Roman Scherzer
ClrMamePro

As soon as I'm home I check if unzipped roms with bad crc32 cause some issue....maybe only in combination with the advanced checksum fixing options.... thanks anyway...stay tuned ;)

Roman Scherzer
ClrMamePro

ok...I'm able to repeat it. It will be fixed in the next cmpro release.

Roman Scherzer
ClrMamePro

Sorry for the slow reply, just woke up. :) Okay, I'm glad you found it. :D

Alyas
"Good... Bad... I'm the guy with the gun."