Hi Roman,

I was wondering if you had any plans (or if it's there already!) to use SHA1 in the Rebuilder? With some people releasing fake roms lately (choko & driveyes), using SHA1 in the Rebuilder process would catch it straight away rather than letting it rebuild in bad roms. I know it catches them in the Scanner if you tick the option, but why build in roms when they don't actually match the information you have at hand? :)

A second thought is about the auto-save / delete fixdat. What would be cool is an option to save the fixdat in the same structure as the datfiles / logs / settings, etc files. It would be nice if this setting was independant from the current option, for the following reason :

I would like to use the auto-save / delete feature, but when a new Mame comes out, I do a scan fixing everything I can then save a fixdat. This essentially becomes my 'diff fixdat' that Mamediff could create. But, if I am using this feature, when I rebuild in the roms required, my fixdat would be deleted. That's just an example, of course, not the entire reason I'd want it.

So, I guess what I'm asking is : Could you put in a 'Auto-save / Delete Structured Fixdat' option that does the above, basically disregards the 'Scanner_LastFixDatFile' setting and saves the file under '{CMP_Path}\fixdats', and in the same folder as the datfile.

Hope that makes sense.....I await your reply of 'bugger off' ;)

SK.

> I was wondering if you had any plans (or if it's there already!) to use SHA1 in
> the Rebuilder?

Plans yes, don't know when it's done though.


> With some people releasing fake roms lately (choko & driveyes)

There are no fake driveyes roms out there. The driver definition is messed up. The roms floating around are the correct ones, but the filesizes have to be fixed in the driver. AFAIK this is already done.

> So, I guess what I'm asking is : Could you put in a 'Auto-save / Delete
> Structured Fixdat' option that does the above, basically disregards the
> 'Scanner_LastFixDatFile' setting and saves the file under '{CMP_Path}\fixdats',
> and in the same folder as the datfile.


The structured layout could be done for the default fixdat saving....lemme reread your requests to understand it fully 8)


Roman Scherzer

> There are no fake driveyes roms out there. The driver definition is messed up.
> The roms floating around are the correct ones, but the filesizes have to be
> fixed in the driver. AFAIK this is already done.

Ah, OK....with the fake Choko's floating around, and fake samples, when you get roms that match the CRC but not the SHA1, it's not hard to make the assumption they're fake too ;)

> The structured layout could be done for the default fixdat saving....lemme
> reread your requests to understand it fully 8)

If you want anything clarified or anything, just let me know ;)

SK.

> If you want anything clarified or anything, just let me know ;)

I guess changing the default fixdat saving to use the same folder structures as the profiler isn't a problem. IIRC as soon as you use a manual (popupmenu) mode to save a fixdatfile (and save it to a different place), it will use that new filename from now on for automatic saves...
so.......hmmmm.....tell me again what you want 8)

Btw.....SHA1 rebuild would be awfully slow....since it has to decompress each found zipfile to calculate the hashvalue.


Roman Scherzer

> I guess changing the default fixdat saving to use the same folder structures as
> the profiler isn't a problem. IIRC as soon as you use a manual (popupmenu) mode
> to save a fixdatfile (and save it to a different place), it will use that new
> filename from now on for automatic saves...
> so.......hmmmm.....tell me again what you want 8)

You've pretty much got it, except to disregard the 'Scanner_LastFixDatFile' setting. I don't want the program to delete fixdats that I manually save. That's the key, there are several occasions that I might manually save a fixdat in a location and I don't want the program to automatically delete it when I've got the roms (I may want to go back to that fixdat to produce a diff update...and we're not just talking about Mame here). However I would still love to be able to use the auto-save / delete functionality. If it just saved / deleted the fixdat in the datfile folder structure, that would leave my manually saved fixdats safe & untouched ;)

> Btw.....SHA1 rebuild would be awfully slow....since it has to decompress each
> found zipfile to calculate the hashvalue.

No slower than the 'Decompress and check SHA1' though, right? :)

> You've pretty much got it, except to disregard the 'Scanner_LastFixDatFile'


Will do some brainstorming later at home.


> No slower than the 'Decompress and check SHA1' though, right? :)

It won't be slower.
hmmm...in fact if I can combine the checks.... Like a preselection of valid roms by a quick crc32 compare and if that one matches, you can optionally test the sha1/md5 value as well....So decompression and hashcalculation can be decreased to the files which most likely match a datfile entry.


Roman Scherzer